Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

internal: Version the inlay hint resolve data #13697

Merged
merged 2 commits into from
Nov 29, 2022
Merged

internal: Version the inlay hint resolve data #13697

merged 2 commits into from
Nov 29, 2022

Conversation

jonas-schievink
Copy link
Contributor

@jonas-schievink jonas-schievink commented Nov 29, 2022

cc #13657
cc #13372
cc #13170

This will make us log an error and return the unmodified inlay hints when the client attempts to resolve inlay hints in a file that has since been modified.

@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Nov 29, 2022
@jonas-schievink
Copy link
Contributor Author

@bors r+

@bors
Copy link
Contributor

bors commented Nov 29, 2022

📌 Commit 335cb26 has been approved by jonas-schievink

It is now in the queue for this repository.

bors added a commit that referenced this pull request Nov 29, 2022
…a, r=jonas-schievink

internal: Version the inlay hint resolve data

cc #13657
cc #13372
cc #13170

This will make us log an error and return the unmodified inlay hints when the client attempts to resolve inlay hints in a file that has since been modified.
@bors
Copy link
Contributor

bors commented Nov 29, 2022

⌛ Testing commit 335cb26 with merge d211046...

@jonas-schievink
Copy link
Contributor Author

@bors r+

@bors
Copy link
Contributor

bors commented Nov 29, 2022

📌 Commit 32f59cf has been approved by jonas-schievink

It is now in the queue for this repository.

@bors
Copy link
Contributor

bors commented Nov 29, 2022

⌛ Testing commit 32f59cf with merge 398a71a...

@bors
Copy link
Contributor

bors commented Nov 29, 2022

☀️ Test successful - checks-actions
Approved by: jonas-schievink
Pushing 398a71a to master...

@bors bors merged commit 398a71a into rust-lang:master Nov 29, 2022
@jonas-schievink jonas-schievink deleted the version-inlay-hint-resolve-data branch November 29, 2022 18:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants