Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't respond with a ContentModified while loading the workspace #13985

Merged
merged 1 commit into from
Jan 19, 2023

Conversation

Veykril
Copy link
Member

@Veykril Veykril commented Jan 19, 2023

Initially this was done to prevent frequent inlay hint flickering, but this causes a lot of problems for a bunch of clients. We can (and already kind of have) move this into the semantic token request handlers instead.

Fixes #10910

@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jan 19, 2023
@Veykril
Copy link
Member Author

Veykril commented Jan 19, 2023

@bors r+

@bors
Copy link
Contributor

bors commented Jan 19, 2023

📌 Commit 7385467 has been approved by Veykril

It is now in the queue for this repository.

@bors
Copy link
Contributor

bors commented Jan 19, 2023

⌛ Testing commit 7385467 with merge 6e52c64...

@bors
Copy link
Contributor

bors commented Jan 19, 2023

☀️ Test successful - checks-actions
Approved by: Veykril
Pushing 6e52c64 to master...

1 similar comment
@bors
Copy link
Contributor

bors commented Jan 19, 2023

☀️ Test successful - checks-actions
Approved by: Veykril
Pushing 6e52c64 to master...

@bors
Copy link
Contributor

bors commented Jan 19, 2023

👀 Test was successful, but fast-forwarding failed: 422 Changes must be made through a pull request.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Stuck at 'rust_analyzer: -32801: waiting for cargo metadata or cargo check'
3 participants