Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Use async block in async fn type inference #14461

Merged
merged 1 commit into from
Apr 1, 2023
Merged

fix: Use async block in async fn type inference #14461

merged 1 commit into from
Apr 1, 2023

Conversation

HKalbasi
Copy link
Member

@HKalbasi HKalbasi commented Apr 1, 2023

fix #14456

At some point we should probably go further and completely desugar async fn in hir lowering.

@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Apr 1, 2023
@Veykril
Copy link
Member

Veykril commented Apr 1, 2023

@bors r+

@bors
Copy link
Contributor

bors commented Apr 1, 2023

📌 Commit 8a6ca86 has been approved by Veykril

It is now in the queue for this repository.

@bors
Copy link
Contributor

bors commented Apr 1, 2023

⌛ Testing commit 8a6ca86 with merge ffb04ae...

@bors
Copy link
Contributor

bors commented Apr 1, 2023

☀️ Test successful - checks-actions
Approved by: Veykril
Pushing ffb04ae to master...

@bors bors merged commit ffb04ae into rust-lang:master Apr 1, 2023
@lnicola lnicola changed the title Use async block in async fn type inference fix: Use async block in async fn type inference Apr 1, 2023
@Veykril Veykril mentioned this pull request Apr 4, 2023
Closed
@HKalbasi HKalbasi mentioned this pull request Apr 9, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Crash at crates/hir-ty/src/mir/eval.rs:1161:52
4 participants
@HKalbasi @Veykril @bors @rustbot