Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Fix pat fragment handling in 2021 edition #14652

Merged
merged 1 commit into from
Apr 24, 2023
Merged

Conversation

Veykril
Copy link
Member

@Veykril Veykril commented Apr 24, 2023

Fixes #9055

The fix isn't that great, but we are kind of forced to do it the quick and hacky way right now since std has changed the matches macro to make use of this now. And for a proper fix we need to track hygiene for identifiers which is a long way off anyways

@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Apr 24, 2023
@Veykril
Copy link
Member Author

Veykril commented Apr 24, 2023

@bors r+

@bors
Copy link
Contributor

bors commented Apr 24, 2023

📌 Commit d1ca505 has been approved by Veykril

It is now in the queue for this repository.

@bors
Copy link
Contributor

bors commented Apr 24, 2023

⌛ Testing commit d1ca505 with merge 707382c...

@bors
Copy link
Contributor

bors commented Apr 24, 2023

☀️ Test successful - checks-actions
Approved by: Veykril
Pushing 707382c to master...

@bors bors merged commit 707382c into rust-lang:master Apr 24, 2023
@Veykril Veykril deleted the pat2021 branch April 24, 2023 20:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support 2021 Edition pat matcher in macro_rules
3 participants