Skip to content

Conversation

@matklad
Copy link
Contributor

@matklad matklad commented May 6, 2023

Now in VS Code "go to next error" (F8) will bring you to the source of a panic.

Now in VS Code "go to next error" (`F8`) will bring you to the source of
a panic.
@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label May 6, 2023
@lnicola
Copy link
Member

lnicola commented May 6, 2023

@bors r+

@bors
Copy link
Contributor

bors commented May 6, 2023

📌 Commit 7bc60f5 has been approved by lnicola

It is now in the queue for this repository.

@bors
Copy link
Contributor

bors commented May 6, 2023

⌛ Testing commit 7bc60f5 with merge 5ee39a6...

@bors
Copy link
Contributor

bors commented May 6, 2023

☀️ Test successful - checks-actions
Approved by: lnicola
Pushing 5ee39a6 to master...

@bors bors merged commit 5ee39a6 into rust-lang:master May 6, 2023
@matklad matklad deleted the matklad/panic-is-a-problem branch May 6, 2023 16:12
@apollo-sturdy
Copy link

@matklad Is there a way to disable this? Since this update I am often confused to see red text in my file names and assume I have a compilation error, and instead just find that it is an error from a very old test run that has since been fixed. Is there already a way to clear these errors?

@matklad
Copy link
Contributor Author

matklad commented Jun 6, 2023

re-running the tests would clear the matched problem.

there’s upstream issue about dismissing obsolete matched problems: microsoft/vscode#66982

@dnut
Copy link

dnut commented Jun 30, 2023

re-running the tests would clear the matched problem.

That's a very unsatisfying solution and not always practical.

there’s upstream issue about dismissing obsolete matched problems: microsoft/vscode#66982

I'm surprised this pr was merged without any kind of mechanism like this in place. And while the linked suggestion would improve things, this feature is still going to be very annoying. At the very least, the problem should disappear as soon as any code files are written to. The problem becomes stale as soon as you start typing, and it's pointless to keep it around any longer.

I think rust-analyzer would be better without this feature as it is right now. I've expressed some more detail at #14977

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

S-waiting-on-review Status: Awaiting review from the assignee but also interested parties.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants