Implement ${count()} metavariable expression
#14878
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
the
S-waiting-on-review
|
Opening as a draft since there are several things I'm uncertain about, but this should be enough to expand well-formed macro calls with |
lowr
force-pushed
the
feat/metavar-expr-count
branch
2 times, most recently
from
bc521f1
to
616aa3f
Compare
lowr
force-pushed
the
feat/metavar-expr-count
branch
from
616aa3f
to
0d4d1d7
Compare
|
Current implementation of rustc has several behaviors I consider a bug or underspecified; see rust-lang/rust#111904, rust-lang/rust#111905. I did implement those behaviors but they are pretty much edge cases and, as I said in my previous comment, we should be able to expand well-defined macros. |
Veykril
approved these changes
May 28, 2023
|
@bors r+ |
|
☀️ Test successful - checks-actions |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements
${count()}metavariable expression for MBE as described in RFC 3086. See this section of the RFC for its semantics.Additionally, this PR changes the type of depth parameter of
${index()}from u32 to usize so as to match how rustc parses it.Part of #11952
Fixes #14871