Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Parse builtin# syntax and add typechecking for builtin#offset_of expression #15557

Merged
merged 3 commits into from
Sep 5, 2023

Conversation

Veykril
Copy link
Member

@Veykril Veykril commented Sep 5, 2023

offset_of! no longer reports a parse error after this
Also removes box syntax, fixes #14504

cc rust-lang/compiler-team#580 #15082

@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Sep 5, 2023
@Veykril Veykril marked this pull request as ready for review September 5, 2023 11:30
@Veykril Veykril changed the title Parse builtin# syntax Parse builtin# syntax and add typechecking for builtin#offset_of expression Sep 5, 2023
@Veykril
Copy link
Member Author

Veykril commented Sep 5, 2023

@bors r+

@bors
Copy link
Contributor

bors commented Sep 5, 2023

📌 Commit 3431d58 has been approved by Veykril

It is now in the queue for this repository.

@bors
Copy link
Contributor

bors commented Sep 5, 2023

⌛ Testing commit 3431d58 with merge caeea45...

@bors
Copy link
Contributor

bors commented Sep 5, 2023

☀️ Test successful - checks-actions
Approved by: Veykril
Pushing caeea45 to master...

@bors bors merged commit caeea45 into rust-lang:master Sep 5, 2023
9 checks passed
@Veykril Veykril changed the title Parse builtin# syntax and add typechecking for builtin#offset_of expression feat: Parse builtin# syntax and add typechecking for builtin#offset_of expression Sep 9, 2023
@Veykril Veykril deleted the builtin-syntax branch September 26, 2023 10:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove box_syntax
3 participants