Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

don't optimize on CI, it isn't faster #1576

Merged
merged 1 commit into from
Jul 22, 2019
Merged

don't optimize on CI, it isn't faster #1576

merged 1 commit into from
Jul 22, 2019

Conversation

matklad
Copy link
Member

@matklad matklad commented Jul 22, 2019

No description provided.

@matklad
Copy link
Member Author

matklad commented Jul 22, 2019

bors r+
🤖

@lnicola
Copy link
Member

lnicola commented Jul 22, 2019

😢

Should we also disable debug on release builds?

@matklad
Copy link
Member Author

matklad commented Jul 22, 2019

Hard question. I bet #1541 would be significantly more difficult to debug if we didn't include debug info in release by default

@matklad
Copy link
Member Author

matklad commented Jul 22, 2019

did #1577 as a middle ground

bors bot added a commit that referenced this pull request Jul 22, 2019
@bors @matklad
Merge #1576 #1577
7c24f8c 
1576: don't optimize on CI, it isn't faster r=matklad a=matklad



1577: smaller debuginfo in release r=matklad a=matklad



Co-authored-by: Aleksey Kladov <aleksey.kladov@gmail.com>
@bors
Copy link
Contributor

bors bot commented Jul 22, 2019

Timed out (retrying...)

bors bot added a commit that referenced this pull request Jul 22, 2019
@bors @matklad
Merge #1576
0de6ef0 
1576: don't optimize on CI, it isn't faster r=matklad a=matklad



Co-authored-by: Aleksey Kladov <aleksey.kladov@gmail.com>
@bors
Copy link
Contributor

bors bot commented Jul 22, 2019

Build succeeded

@bors bors bot merged commit 3ea530c into master Jul 22, 2019
@bors bors bot deleted the remove-opt branch July 22, 2019 17:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@matklad @lnicola