Improve completion label details display #15956
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
the
S-waiting-on-review
lnicola
approved these changes
Nov 24, 2023
lnicola
reviewed
Nov 24, 2023
lnicola
reviewed
Nov 24, 2023
|
@bors r+ |
bors
added a commit
that referenced
this pull request
Nov 24, 2023
Improve completion label details display This PR improves completion label details display by separating trait and alias info from the `label` LSP field to an additional existing `label_detail` field. Changes look like the following: ### Before  ### After  _All existing tests are passed without any changes in test themselves logic._
|
@bors r- |
|
@bors r+ |
|
@lnicola As I understand @bors will complete this PR as it saw it on the f8bf1dc commit. |
|
I think it's using the new version now: 8733728. |
|
@lnicola Thank you for such fast assisting and approval of this changes! |
|
☀️ Test successful - checks-actions |
bors
added a commit
that referenced
this pull request
Nov 25, 2023
fix: add fallback for completion label details This PR adds a fallback to a previous implementation in a case when the label detail field isn't supported by LSP client and the support isn't reported by the LSP initialize request. In this case additional info about trait and aliases would be merged into the label field as it was before the #15956 PR.
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR improves completion label details display by separating trait and alias info from the
labelLSP field to an additional existinglabel_detailfield. Changes look like the following:Before
After
All existing tests are passed without any changes in test themselves logic.