Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

internal: Update world symbols request definiton, prefer focus range for macros #16182

Merged
merged 1 commit into from
Dec 22, 2023

Conversation

Veykril
Copy link
Member

@Veykril Veykril commented Dec 22, 2023

Prior to this, the symbol search would always jump to the defining macro call, not it jumps to the name in the macro call input if possible. This is a large improvement for assoc items in an attribute impl or trait.

@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Dec 22, 2023
@Veykril
Copy link
Member Author

Veykril commented Dec 22, 2023

@bors r+

@bors
Copy link
Contributor

bors commented Dec 22, 2023

📌 Commit 7738517 has been approved by Veykril

It is now in the queue for this repository.

@bors
Copy link
Contributor

bors commented Dec 22, 2023

⌛ Testing commit 7738517 with merge b215d07...

bors added a commit that referenced this pull request Dec 22, 2023
internal: Update world symbols request definiton, prefer focus range for macros

Prior to this, the symbol search would always jump to the defining macro call, not it jumps to the name in the macro call input if possible. This is a large improvement for assoc items in an attribute impl or trait.
@bors
Copy link
Contributor

bors commented Dec 22, 2023

💔 Test failed - checks-actions

@Veykril Veykril force-pushed the world-symbols-focus-range branch from 7738517 to dca0e2e Compare December 22, 2023 10:34
@Veykril
Copy link
Member Author

Veykril commented Dec 22, 2023

@bors r+

@bors
Copy link
Contributor

bors commented Dec 22, 2023

📌 Commit dca0e2e has been approved by Veykril

It is now in the queue for this repository.

@bors
Copy link
Contributor

bors commented Dec 22, 2023

⌛ Testing commit dca0e2e with merge cd6a96f...

bors added a commit that referenced this pull request Dec 22, 2023
internal: Update world symbols request definiton, prefer focus range for macros

Prior to this, the symbol search would always jump to the defining macro call, not it jumps to the name in the macro call input if possible. This is a large improvement for assoc items in an attribute impl or trait.
@bors
Copy link
Contributor

bors commented Dec 22, 2023

💔 Test failed - checks-actions

@Veykril Veykril force-pushed the world-symbols-focus-range branch from dca0e2e to 2a5b60b Compare December 22, 2023 10:42
@Veykril
Copy link
Member Author

Veykril commented Dec 22, 2023

@bors r+

@bors
Copy link
Contributor

bors commented Dec 22, 2023

📌 Commit 2a5b60b has been approved by Veykril

It is now in the queue for this repository.

@bors
Copy link
Contributor

bors commented Dec 22, 2023

⌛ Testing commit 2a5b60b with merge d2dacc0...

@bors
Copy link
Contributor

bors commented Dec 22, 2023

☀️ Test successful - checks-actions
Approved by: Veykril
Pushing d2dacc0 to master...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants