-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
internal: Update to latest rustc_pattern_analysis
#16533
Conversation
e930ff9
to
b04e0df
Compare
About the test, I can see some panic with this test: check_diagnostics_no_bails(
r#"
//- minicore: option
fn main() {
match Some((true, false)) {
Some(true) | Some(false) => {}
None => {}
}
}
"#,
); |
Oh perfect, |
I changed it to |
I think ideally But removing the |
☀️ Test successful - checks-actions |
rustc_pattern_analysis
rustc_pattern_analysis
That was supposed to be the case, this PR is for the edge cases where we fall to catch the type error |
Here I go again. Two improvements this time.
cx.bug()
callsnever!()
but I'm not sure whatnever!()
does. Does it display anything to the user? Otherwise adebug!()
should be sufficient.Point 2 should fix #15883 but I haven't tested it because I'm not sure how to reproduce. Could someone give me pointers as to how to write a test for the pattern code?