fix: Various find path fixes #17277
Merged
fix: Various find path fixes #17277
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
the
S-waiting-on-review
davidbarsky
approved these changes
May 22, 2024
Comment on lines
91
to
+93
| prefer_no_std: bool, | ||
| prefer_prelude: bool, | ||
| ignore_local_imports: bool, |
There was a problem hiding this comment.
i suspect that #17252 might help here: i found myself getting confused by the booleans in other contexts 😅
There was a problem hiding this comment.
Right, guess I'll fix up the conflicts after merging this then 😬
There was a problem hiding this comment.
Although that field is not meant to be public API like is the case with the other two.
|
@bors r+ |
|
☀️ Test successful - checks-actions |
This was referenced May 28, 2024
This was referenced Jun 1, 2024
This was referenced Jun 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #17271