Skip to content

fix: Skip match exhaustiveness checking if pattern type contains errors #17534

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 3, 2024
Merged

fix: Skip match exhaustiveness checking if pattern type contains errors #17534

merged 1 commit into from
Jul 3, 2024

Conversation

@Veykril
Copy link
Member

@Veykril Veykril commented Jul 3, 2024

Should fix #17509, checking when errors are involved is generally a bad idea as the algorithm doesn't really expect error types in the first place I believe

@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jul 3, 2024
@Veykril
Copy link
Member Author

Veykril commented Jul 3, 2024

@bors r+

@bors
Copy link
Contributor

bors commented Jul 3, 2024

📌 Commit 26c7bfd has been approved by Veykril

It is now in the queue for this repository.

@bors
Copy link
Contributor

bors commented Jul 3, 2024

⌛ Testing commit 26c7bfd with merge 848e0c4...

@bors
Copy link
Contributor

bors commented Jul 3, 2024

☀️ Test successful - checks-actions
Approved by: Veykril
Pushing 848e0c4 to master...

@bors bors merged commit 848e0c4 into rust-lang:master Jul 3, 2024
@lnicola lnicola mentioned this pull request Jul 13, 2024
Closed
@ShoyuVanilla ShoyuVanilla mentioned this pull request Jul 20, 2024
Merged
bors added a commit that referenced this pull request Jul 20, 2024
@bors
Auto merge of #17649 - ShoyuVanilla:issue-17585, r=Veykril
8d489e2 
fix: Panic in debug profile for tuple deconstruct with arity mismatch

Fixes #17585, which doesn't affect daily use cases but quite annoying in development of r-a itself like writing tests.

This PR applies similar approach as in #17534, skipping match usefulness check for patterns containing errors
@Veykril Veykril deleted the skip-unknown-match-check branch September 9, 2024 11:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

S-waiting-on-review Status: Awaiting review from the assignee but also interested parties.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

entered unreachable code: uncaught type error: pattern (_ : {error}, _ : {error}) has inconsistent arity

3 participants

@Veykril @bors @rustbot