Preliminary work for #17940 #17941
Merged
Preliminary work for #17940 #17941
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
the
S-waiting-on-review
ChayimFriedman2
force-pushed
the
pre-closure-to-fn
branch
from
6898acb to
a28eca6
Compare
Veykril
reviewed
Aug 23, 2024
| full_range: 7800..8008, | ||
| full_range: 7800..8042, |
There was a problem hiding this comment.
We really need to do something about these tests its so annoying that touching minicore keeps changing this (not for you to do specifically, just a remark)
Veykril
reviewed
Aug 23, 2024
Also create a test infrastructure for capture computation.
ChayimFriedman2
force-pushed
the
pre-closure-to-fn
branch
from
a28eca6 to
4fe1dc4
Compare
This is important for the "convert closure to fn" assist, as it needs to find and modify the places the captures are used.
We don't yet lower or maybe even parse them, but blocks already have `gen`, so why not.
Previously we were ignoring them.
This will be needed as we parse unknown identifiers and want to insert them into source code.
We can impl PartialOrd and Ord too, but I didn't need that.
ChayimFriedman2
force-pushed
the
pre-closure-to-fn
branch
from
4fe1dc4 to
52462ad
Compare
|
Addressed comments and added explanation about span stacks. |
|
Cool, thanks for the extra comments. Will merge this after tomorrows release |
Veykril
approved these changes
Aug 25, 2024
|
@bors r+ |
|
☀️ Test successful - checks-actions |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I split the PR as requested, and made small commits.