Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not report missing unsafe on addr_of[_mut]!(EXTERN_OR_MUT_STATIC) #18003

Merged
merged 2 commits into from
Aug 30, 2024

Conversation

ChayimFriedman2
Copy link
Contributor

The compiler no longer does as well; see rust-lang/rust#125834.

Also require unsafe when accessing extern static (other than by addr_of!()).

Fixes #17978.

@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Aug 29, 2024
@Veykril
Copy link
Member

Veykril commented Aug 30, 2024

@bors r+

@bors
Copy link
Contributor

bors commented Aug 30, 2024

📌 Commit 91f2016 has been approved by Veykril

It is now in the queue for this repository.

@bors
Copy link
Contributor

bors commented Aug 30, 2024

⌛ Testing commit 91f2016 with merge 13ac53e...

@bors
Copy link
Contributor

bors commented Aug 30, 2024

☀️ Test successful - checks-actions
Approved by: Veykril
Pushing 13ac53e to master...

@bors bors merged commit 13ac53e into rust-lang:master Aug 30, 2024
11 checks passed
@ChayimFriedman2 ChayimFriedman2 deleted the addr_of-static-mut branch October 16, 2024 04:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Missing unsafe block error where rustc doesn't give an error
4 participants