Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Fix printing of constants greater than i128::MAX #18119

Merged
merged 1 commit into from
Sep 15, 2024

Conversation

ChayimFriedman2
Copy link
Contributor

Fixes #18116.

@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Sep 15, 2024
@ChayimFriedman2 ChayimFriedman2 changed the title Fix printing of constants greater than i128::MAX fix: Fix printing of constants greater than i128::MAX Sep 15, 2024
@HKalbasi
Copy link
Member

@bors r+

@bors
Copy link
Contributor

bors commented Sep 15, 2024

📌 Commit 798c963 has been approved by HKalbasi

It is now in the queue for this repository.

@bors
Copy link
Contributor

bors commented Sep 15, 2024

⌛ Testing commit 798c963 with merge 94b526f...

@bors
Copy link
Contributor

bors commented Sep 15, 2024

☀️ Test successful - checks-actions
Approved by: HKalbasi
Pushing 94b526f to master...

1 similar comment
@bors
Copy link
Contributor

bors commented Sep 15, 2024

☀️ Test successful - checks-actions
Approved by: HKalbasi
Pushing 94b526f to master...

@bors bors merged commit 94b526f into rust-lang:master Sep 15, 2024
11 checks passed
@bors
Copy link
Contributor

bors commented Sep 15, 2024

👀 Test was successful, but fast-forwarding failed: 422 Changes must be made through a pull request.

@bors
Copy link
Contributor

bors commented Sep 15, 2024

☔ The latest upstream changes (presumably #18119) made this pull request unmergeable. Please resolve the merge conflicts.

@ChayimFriedman2 ChayimFriedman2 deleted the signed-const branch October 6, 2024 22:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Signed u128 output
4 participants