fix: Temporary fix for remove_unused_imports not handling import aliases correctly
#18164
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
the
S-waiting-on-review
ShoyuVanilla
force-pushed
the
use-as-alias
branch
from
ec74b70 to
8ded5a9
Compare
Veykril
reviewed
Sep 24, 2024
| @@ -447,6 +449,11 @@ impl<'a> FindUsages<'a> { | |||
| self | |||
| } | |||
|
|
|||
| pub fn with_rename(mut self, rename: Option<&'a Rename>) -> Self { | |||
There was a problem hiding this comment.
This should be a temporary thing. Ideally this would trivially fix itself once we handle renamed uses as proper Definitions. So a FIXME would be nice. #14079
There was a problem hiding this comment.
Oh, that's right. This should be handled as TypeAlias, right? I'll add a comment and modify the commit and PR message
There was a problem hiding this comment.
No, not a type alias. The idea is that we will record use foo as bar as their own kind of Definition, Definition::Use whose name would be the rename, effectively treating renaming imports as their own item.
ShoyuVanilla
changed the title
remove_unused_importsremove_unused_imports
ShoyuVanilla
force-pushed
the
use-as-alias
branch
from
8ded5a9 to
d4de84f
Compare
ShoyuVanilla
changed the title
remove_unused_importsremove_unused_imports not handling import aliases correctly
|
@bors r+ |
|
☀️ Test successful - checks-actions |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #18129