Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
First PR here (yay!), so I read some of the getting started docs. There are a couple references to
handlers.rs
, which as far as I can tell has been refactored intohandlers/*.rs
. I made some tweaks to that in one commit. There is one fixme about a function calledto_lsp_runnable
, which I can't find anywhere at all. I can update that if I get some more info there.Otherwise I changed references to object safety, is object safe, etc., trying to match case/style as I went. There was one case I found where there's a trait from somewhere else called
is_object_safe
, which I found defined in my cargo registry. I didn't touch that for now, just marked it with a fixme