Skip to content

Conversation

noahmbright
Copy link
Contributor

First PR here (yay!), so I read some of the getting started docs. There are a couple references to handlers.rs, which as far as I can tell has been refactored into handlers/*.rs. I made some tweaks to that in one commit. There is one fixme about a function called to_lsp_runnable, which I can't find anywhere at all. I can update that if I get some more info there.

Otherwise I changed references to object safety, is object safe, etc., trying to match case/style as I went. There was one case I found where there's a trait from somewhere else called is_object_safe, which I found defined in my cargo registry. I didn't touch that for now, just marked it with a fixme

@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Sep 28, 2024
@noahmbright
Copy link
Contributor Author

Closes #18185

@ShoyuVanilla
Copy link
Member

ShoyuVanilla commented Sep 29, 2024

There was one case I found where there's a trait from somewhere else called is_object_safe, which I found defined in my cargo registry.

Do you mean https://doc.rust-lang.org/nightly/nightly-rustc/rustdoc_json_types/struct.Trait.html#structfield.is_object_safe ? It has nothing to do with rust-analyzer because it's for building rustdoc. BTW I think that this should be merged after rust-lang/lang-team#286 because "dyn compatiblity" is not an official term until it's done

@HKalbasi
Copy link
Member

BTW I think that this should be merged after rust-lang/lang-team#286 because "dyn compatiblity" is not an official term until it's done

Its FCP is completed so it is effectively done.

Up to a trait implemented by another package, linking to
$CARGO_HOME/registry/cache/index.crates.io-6f17d22bba15001f/
@HKalbasi
Copy link
Member

Thanks!
@bors r+

@bors
Copy link
Contributor

bors commented Sep 29, 2024

📌 Commit 4255cae has been approved by HKalbasi

It is now in the queue for this repository.

@bors
Copy link
Contributor

bors commented Sep 29, 2024

⌛ Testing commit 4255cae with merge 822644d...

@bors
Copy link
Contributor

bors commented Sep 29, 2024

☀️ Test successful - checks-actions
Approved by: HKalbasi
Pushing 822644d to master...

@bors bors merged commit 822644d into rust-lang:master Sep 29, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants