Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Use snippet placeholders for generated match arms #18459

Merged
merged 2 commits into from
Nov 19, 2024
Merged

feat: Use snippet placeholders for generated match arms #18459

merged 2 commits into from
Nov 19, 2024

Conversation

Giga-Bowser
Copy link
Contributor

When generating missing match arms, we currently use todo!()s for the match arm bodies. This is fine, but given they're obviously meant to be replaced, I figure they should also be snippet placeholders.

@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Nov 1, 2024
DropDemBits
DropDemBits approved these changes Nov 5, 2024
View reviewed changes
Copy link
Contributor

@DropDemBits DropDemBits left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All good!

@Giga-Bowser Giga-Bowser mentioned this pull request Nov 9, 2024
Open
@Giga-Bowser
Copy link
Contributor Author

I know I said I would migrate this to the new SyntaxEditor API earlier, but that's actually been tougher than I expected, so it should probably go in it's own PR. Once this PR is merged I'll open another and outline the migration there.

@lnicola lnicola added this pull request to the merge queue Nov 19, 2024
Merged via the queue into rust-lang:master with commit e761618 Nov 19, 2024
9 checks passed
@Giga-Bowser Giga-Bowser deleted the match-placeholders branch December 8, 2024 22:45
@ShoyuVanilla ShoyuVanilla mentioned this pull request Feb 13, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lnicola lnicola lnicola approved these changes

@DropDemBits DropDemBits DropDemBits approved these changes

Assignees
No one assigned
Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Giga-Bowser @lnicola @DropDemBits @rustbot