Migrate sort_items Assist to Use SyntaxFactory
#18538
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
the
S-waiting-on-review
darichey
suggested changes
Nov 22, 2024
There was a problem hiding this comment.
Mostly looks good, a couple opportunities for simplification.
Not for this PR, but after doing a few of these, it looks like there may be potential for a slightly nicer api that takes care of some things for us. Something like:
fn add_with_editor(
&mut self,
id: AssistId,
label: impl Into<String>,
target: SyntaxNode,
f: impl FnOnce(&mut SyntaxEditor, &SyntaxFactory),
) -> Option<()>
tareknaser
force-pushed
the
syntax_factory_sort_items
branch
from
6f727e0 to
552206d
Compare
darichey
suggested changes
Dec 4, 2024
Signed-off-by: Tarek <tareknaser360@gmail.com>
Signed-off-by: Tarek <tareknaser360@gmail.com>
tareknaser
force-pushed
the
syntax_factory_sort_items
branch
from
552206d to
c43d565
Compare
davidbarsky
approved these changes
Dec 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
part of #15710 and #18285
For this one, I had to pass
AssistContextto other methods as well in order to get the file ID.