fix: copied proc-macros not being cleaned up on exit #18660
Conversation
rustbot
added
the
S-waiting-on-review
Veykril
changed the title
Veykril
force-pushed
the
push-snumrtvzwqvw
branch
from
dd7977f to
953906b
Compare
Veykril
force-pushed
the
push-snumrtvzwqvw
branch
from
953906b to
16c0f25
Compare
There was a problem hiding this comment.
Can anyone inform me about what's unsafe about https://docs.rs/memmap/latest/memmap/struct.Mmap.html#method.map, given the docs don't state it?
|
Is that the right crate? I suspect it's because another process can truncate or change the file while you're reading from it. See also https://docs.rs/memmap2/latest/memmap2/struct.Mmap.html#safety. |
|
Ah okay, so I was right. That means technically our usages are unsound ... is there even a need for memory mapping here? We only access parts of the file anyways and its not a lot of files we are touching either Ah I see, you added that in #4004 due to memory usage |
|
I'm not to worried about the memory maps causing a crash. I think there's a very small window when we have the library mapped, but not loaded. |
No description provided.