More rustfmt hang investigations #19080
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
the
S-waiting-on-review
Veykril
commented
Feb 2, 2025
| let vfs = &mut self.vfs.write().0; | ||
|
|
||
| let vfs = &self.vfs.read().0; |
There was a problem hiding this comment.
This could've caused some requests (including formatting) to wait on acquiring their read lock when we were recreating the crate graph. This was needed to be a write lock before, but we've since changed the loading behavior here, so this is no longer the case.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We desperately need to build better perf monitoring infra, the
RA_PROFILEsetup is honestly quite useless