fix: negative nums in concat! expansion
#19434
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
the
S-waiting-on-review
vishruth-thimmaiah
force-pushed
the
negatives_in_concat
branch
from
bd5bd0d to
2eeccd5
Compare
vishruth-thimmaiah
force-pushed
the
negatives_in_concat
branch
from
2eeccd5 to
ca352e0
Compare
|
Hey @Veykril, sorry about the ping. Unfortunately, I'm suffering immensely from this bug. The fix here seems to be pretty simple to me. How hard would it be for this to be merged? Thanks for the great work you are putting into Rust Analyzer! |
pedrocarlo
added a commit
to pedrocarlo/limbo
that referenced
this pull request
Apr 27, 2025
…yzer bug that incorrectly expands negative integers in proc_macros: rust-lang/rust-analyzer#19434
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #19417
This PR provides a fix to the expansion of the
concat!macro, where negative numbers give anunexpected tokenerror.expands to: