fix: Fix panicking while resolving callable sigs for AsyncFnMut
#20971
+32
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
the
S-waiting-on-review
ShoyuVanilla
changed the title
AsyncFnXsAsyncFnMut
crates/hir-ty/src/infer/unify.rs
Outdated
| let trait_ref = TraitRef::new(self.interner(), fn_trait.into(), args); | ||
|
|
||
| let mut proj_args: SmallVec<[_; 3]> = | ||
| GenericArgs::identity_for_item(self.interner(), output_assoc_type.into()) |
Contributor
There was a problem hiding this comment.
You can use GenericArgs::fill_rest(), it's nicer and more efficient.
ShoyuVanilla
force-pushed
the
async-fn-sig
branch
from
220812c to
e8c5dc1
Compare
ChayimFriedman2
requested changes
Nov 4, 2025
crates/hir-ty/src/infer/unify.rs
Outdated
| self.interner(), | ||
| output_assoc_type.into(), | ||
| args.into_iter().map(Into::into), | ||
| |idx, id, _| mk_param(self.interner(), idx, id), |
Contributor
There was a problem hiding this comment.
Is using a Param for this correct? Despite what shown in tests, it will be interpreted as a param for the calling function, which will result... weird things. An inference var should be probably? Or look at what rustc does.
Member
Author
There was a problem hiding this comment.
Yeah, rustc's implementation is a bit different (maybe we should change ours to match with it) but using inference vars sounds correct
https://github.com/rust-lang/rust/blob/e5efc336720901420a8891dcdb67ca0a475dc03c/compiler/rustc_hir_typeck/src/method/mod.rs#L424-L429
ShoyuVanilla
force-pushed
the
async-fn-sig
branch
from
e8c5dc1 to
c7c9e25
Compare
ChayimFriedman2
approved these changes
Nov 4, 2025
rustbot
removed
the
S-waiting-on-review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #20951
AsyncFnMut::CallRefFuturehas a lifetime parameter, so its generic params has length 3(trait self + args tuple + lifetime)