feat: Add bidirectional messaging proc-macro-srv prototype #21249
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Shourya742
force-pushed
the
2025-11-27-bidirectional-protocol
branch
4 times, most recently
from
0a41ccb to
bb61e2e
Compare
Shourya742
force-pushed
the
2025-11-27-bidirectional-protocol
branch
from
bb61e2e to
376bca9
Compare
Shourya742
force-pushed
the
2025-11-27-bidirectional-protocol
branch
from
339c074 to
57fdf52
Compare
Shourya742
force-pushed
the
2025-11-27-bidirectional-protocol
branch
from
a01d06d to
19e816d
Compare
rustbot
added
the
S-waiting-on-review
ChayimFriedman2
requested changes
Dec 21, 2025
Contributor
ChayimFriedman2
left a comment
ChayimFriedman2
left a comment
There was a problem hiding this comment.
Overall good code, left some comments.
@Veykril would you like to review this too?
Veykril
reviewed
Dec 21, 2025
Veykril
reviewed
Dec 21, 2025
…pe and remove JsonNew
Shourya742
force-pushed
the
2025-11-27-bidirectional-protocol
branch
from
92ae11e to
336f025
Compare
Veykril
reviewed
Dec 23, 2025
Shourya742
force-pushed
the
2025-11-27-bidirectional-protocol
branch
from
df4a87f to
9b03499
Compare
ChayimFriedman2
approved these changes
Dec 23, 2025
Shourya742
force-pushed
the
2025-11-27-bidirectional-protocol
branch
from
e04b4bb to
41dade9
Compare
Veykril
approved these changes
Dec 26, 2025
Member
Veykril
left a comment
Veykril
left a comment
There was a problem hiding this comment.
I got some smaller thoughts about how stuff is done/organized here but I don't think that needs to be done for this PR, so lets unblock this for now given I have put down most of those thoughts on the zulip thread
Veykril
changed the title
rustbot
removed
the
S-waiting-on-review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a bidirectional proc-macro protocol so the server can ask the client for data while expanding a macro . The approach is still synchronous and single-request-at-a-time. The server may emit sub-requests during expansion, the client replies immediately, and the server then finishes with the final response. All messages use the same request id, and stdin/stdout remain strictly ordered. Legacy protocols are untouched