fix: handle ref mut bindings in contains_explicit_ref_binding#21647
Merged
ChayimFriedman2 merged 1 commit intorust-lang:masterfrom Feb 15, 2026
Merged
Conversation
rustbot
added
the
S-waiting-on-review
Contributor
|
Can you add a test? |
Contributor
Author
the standalone `contains_explicit_ref_binding` function only checked for `BindingAnnotation::Ref`, missing `BindingAnnotation::RefMut`. this caused `let ref mut x = expr` to incorrectly take the coercion path instead of preserving the exact type of the rhs expression. the method version used for match arms already handles both `Ref` and `RefMut` correctly.
Albab-Hasan
force-pushed
the
fix/contains-explicit-ref-binding-missing-refmut
branch
from
a4f1362 to
a78e873
Compare
Contributor
Author
|
@ChayimFriedman2 hey, is this good? pls let me know. |
Contributor
Author
|
@ChayimFriedman2 hey is there anyway I can ask you some questions if you dont mind? |
rustbot
removed
the
S-waiting-on-review
Contributor
|
On Zulip is a good idea. |
Contributor
Author
|
@ChayimFriedman2 ok, do you have a org or smth? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
the standalone
contains_explicit_ref_bindingfunction only checked forBindingAnnotation::Ref, missingBindingAnnotation::RefMut. this causedlet ref mut x = exprto incorrectly take the coercion path instead of preserving the exact type of the rhs expression. the method version used for match arms already handles bothRefandRefMutcorrectly.