"Insert explicit type " assist fix #2869, fix typo #2877
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
matklad
reviewed
Jan 19, 2020
| @@ -34,6 +35,14 @@ pub(crate) fn add_explicit_type(ctx: AssistCtx<impl HirDatabase>) -> Option<Assi | |||
| // The binding must have a name | |||
| let name = pat.name()?; | |||
| let name_range = name.syntax().text_range(); | |||
| // Assist should only be applicable if cursor is between 'let' and '=' | |||
| let stmt_range = stmt.syntax().text_range(); | |||
| let eq_range = stmt.syntax().descendants_with_tokens().find(|t| t.kind() == EQ)?.text_range(); | |||
There was a problem hiding this comment.
Let’s add an eq_token method to ast::LetStmt, so that it can be used elsewhere. There’s extensions.rs module for that
There was a problem hiding this comment.
Other than this, looks good to me!
matklad
reviewed
Jan 19, 2020
|
|
||
| pub fn eq_token(&self) -> Option<SyntaxToken> { | ||
| self.syntax() | ||
| .descendants_with_tokens() |
There was a problem hiding this comment.
Oh, we should also use children instead of descendants here: descendants is recursive, and so can be much slower. Everything is ok!
bors d+
There was a problem hiding this comment.
Oh, I see. Is there any documentation for Rowan ?
There was a problem hiding this comment.
Nope :-(
Though, the API is stable-ish now, so writing docs should be a good investment. There's api_walkthoruh test which might be helpful.
|
bors r+ |
bors bot
added a commit
that referenced
this pull request
Jan 20, 2020
2877: "Insert explicit type " assist fix #2869, fix typo r=matklad a=TomasKralCZ So this was quite straightforward. I basically looked at how the other assists work and tried doing something simillar. I also fixed a typo in the other assist. Co-authored-by: TomasKralCZ <tomas@kral.hk>
Build succeeded
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
So this was quite straightforward. I basically looked at how the other assists work and tried doing something simillar. I also fixed a typo in the other assist.