Rework value parameter parsing #3040
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- `Fn__(...)` parameters with idents/patterns no longer parse - Trait function parameters with arbitrary patterns parse - Trait function parameters without idents/patterns no longer parse - `fn(...)` parameters no longer parse with patterns other than a single ident
matklad
reviewed
Feb 7, 2020
| @@ -1 +1 @@ | |||
| type F = Box<Fn(a: i32, &b: &i32, &mut c: &i32, ())>; | |||
There was a problem hiding this comment.
Wait, this was never allowed in the first place? 😅
There was a problem hiding this comment.
Maybe add some code to test all code which should compile with rustc too?
There was a problem hiding this comment.
That could be a good catch-all, but I think a lot of existing tests won't compile due to undefined symbols, rather than syntax errors.
|
bors r+ |
bors bot
added a commit
that referenced
this pull request
Feb 7, 2020
3040: Rework value parameter parsing r=matklad a=tobz1000 Fixes #2847. - `Fn__(...)` parameters with idents/patterns no longer parse - Trait function parameters with arbitrary patterns parse - Trait function parameters without idents/patterns no longer parse - `fn(...)` parameters no longer parse with patterns other than a single ident __Question__: The pre-existing test `param_list_opt_patterns` has been kept as-is, although the name no longer makes sense (it's testing `Fn__(...)` params, which aren't allowed patterns any more). What would be best to do about this? Co-authored-by: Toby Dimmick <tobydimmick@pm.me>
Build succeeded
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2847.
Fn__(...)parameters with idents/patterns no longer parsefn(...)parameters no longer parse with patterns other than a single identQuestion: The pre-existing test
param_list_opt_patternshas been kept as-is, although the name no longer makes sense (it's testingFn__(...)params, which aren't allowed patterns any more). What would be best to do about this?