Implementation of lazy assits #4717
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mcrakhman
changed the title
# Conflicts: # crates/rust-analyzer/src/to_proto.rs
matklad
reviewed
Jun 3, 2020
matklad
reviewed
Jun 3, 2020
# Conflicts: # crates/rust-analyzer/src/main_loop/handlers.rs # crates/rust-analyzer/src/to_proto.rs
|
@matklad Seems I've fixed the comments, now I will revert back the changes in extract_enum, so there will only be code related to the assist itself |
|
bors r+ |
kjeremy
reviewed
Jun 3, 2020
| @@ -202,6 +218,8 @@ impl Request for CodeActionRequest { | |||
| pub struct CodeAction { | |||
There was a problem hiding this comment.
This is missing pub diagnostics: Option<Vec<Diagnostic>>,. In addition it is going to conflict with edit in 3.16.
There was a problem hiding this comment.
We don’t use diagnostics, so that’s why it is missing. What exactly changes in edit in 3.16?
There was a problem hiding this comment.
Ignore me. I was thinking of insert/replace edits in CompletionItem
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.