Update chalk to 0.28.0 #6076
Merged
Update chalk to 0.28.0 #6076
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lnicola
reviewed
Sep 25, 2020
vandenheuvel
force-pushed
the
update_chalk_version
branch
from
4f9ba55 to
dff6895
Compare
|
bors r+ Thanks! |
|
Hm, seems likely that this introduced a crash on analysis-stats for rust-analyzer itself: https://github.com/rust-analyzer/rust-analyzer/runs/1174103663?check_suite_focus=true#step:9:18 |
|
cc @flodiebold |
|
I'll try to look into it today or tomorrow. |
|
Thanks! |
|
Apparently it's been fixed already: rust-lang/chalk#613 |
|
Splendid! I wonder if we should add a test for this? |
|
Hmm, a test for this specific case will be added to Chalk, so I don't know whether a specific test case will help here, and I don't know if we can write a more general test... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.