Split punctuation semantic highlighting up into more tags #6238
Conversation
| @@ -599,7 +599,10 @@ fn highlight_element( | |||
| _ if element.parent().and_then(ast::Attr::cast).is_some() => { | |||
| HighlightTag::Attribute.into() | |||
| } | |||
| _ => HighlightTag::Punctuation.into(), | |||
| k => match punctuation_modifiers(k) { | |||
| Some(modifier) => Highlight::new(HighlightTag::Punctuation) | modifier, | |||
There was a problem hiding this comment.
Hm, I think we should have Tag::Punctuation(Bracket | Brace ...), abusing modifiers for this at this level feels wrong.
But probably the best way to lower that to lsp in lsp_conv is indeed via modifiers: IIRC, they planned, but didn't ship inheritance for highlight tags. so we can't have punctuation.brace, where both things are tags. But better to double-check this.
|
Stats: blocked on moving kinds of punctuations to tags: #6238 (comment) |
|
ping @Veykril ) |
|
Kind of forgot about this PR 😅 This should be what you had in mind I believe right? |
Veykril
changed the title
| HlTag::Punctuation(punct) => match punct { | ||
| HlPunct::Bracket => "bracket", | ||
| HlPunct::Brace => "brace", | ||
| HlPunct::Parenthesis => "parentheses", |
There was a problem hiding this comment.
Hmm.
This is the plural, I think.
There was a problem hiding this comment.
Oof, how do I run the HTML highlighting tests? Even with RUN_SLOW_TEST=1 cargo test nothing fails after changing that line.
There was a problem hiding this comment.
Never mind, saving the changed files is a good idea 😄.
Open question would be the name of the delimiter modifiers. I chose them this was as I see them this way but from what I remember people tend to mix the names however they like. So maybe using
delimSquare,delimCurly,delimRoundwould be better. That would also go well withanglebecomingdelimAngle?Closes #6152