Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove TextMate grammar #6984

Merged
merged 1 commit into from
Dec 22, 2020
Merged

Remove TextMate grammar #6984

merged 1 commit into from
Dec 22, 2020

Conversation

lnicola
Copy link
Member

@lnicola lnicola commented Dec 21, 2020

Closes #6267

This is now included upstream in VS Code.

It's now included upstream in VS Code
@lnicola
Copy link
Member Author

lnicola commented Dec 21, 2020

r? @dustypomerleau

@dustypomerleau
Copy link
Contributor

bors r+

Thanks for all the feedback on this. I agree it's time to remove - will simplify maintenance and give users more control.

@bors
Copy link
Contributor

bors bot commented Dec 22, 2020

🔒 Permission denied

Existing reviewers: click here to make dustypomerleau a reviewer

@dustypomerleau
Copy link
Contributor

Ah - appears I don't have the permissions to merge, @lnicola.

@lnicola
Copy link
Member Author

lnicola commented Dec 22, 2020

bors r=dustypomerleau

@bors
Copy link
Contributor

bors bot commented Dec 22, 2020

@bors bors bot merged commit 61711d9 into rust-lang:master Dec 22, 2020
@lnicola lnicola deleted the rm-tm-grammar branch December 22, 2020 04:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Latest nightly seems to ignore semantic highlighting settings
2 participants