-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ignore qualifiers when doing autoimport completions lookup #7064
Conversation
704be75
to
77b4a1c
Compare
Well, I'm not completely certain that this is correct, but it's too good to not have it in nightly versions (so it has some time to bake). @matklad you should probably still review this when you're back. |
bors r+ |
lgtm!
Yeah, I've decided to use the Christmass break to switch to the workman layout: https://workmanlayout.org. My productivity tanked, but I've already clawed back like 20wpm! :D |
shudders I tried Colemak for a while in another life, but gave up after a month or so. |
Would you recommend it over the old favourites (Colemak and Dvorak)? |
Yeah we'll need a blog post about this. |
I'll do one in about a year. From my research, dvorak seems significantly worse than modern alternatives (its from 30s!), and colemac, workman & noreman are roughly equivalent. |
Also (and the thing that motivated the switch for me), Russian йцукен is believed to be better than qwerty, and I do type significantly faster in Russian, despite typing in English more overall. Not sure if this is layout or native vs foreign language thing. |
FWIW, I'm using workman, and am mostly happy with it, but sometimes wish I'd have chosen a layout that's more widely supported (see also), and think that probably the differences between these layouts (colemak etc., not qwerty) matter much less than the effect of learning to touch-type properly. (I.e. choosing one and sticking to it is much more important than the concrete choice.) |
I clicked on a link in the changelog to check out an interesting change but found an interesting conversation. :)
I also type more in English (qwerty) than in Russian and I do type slower in Russian than in English so ¯\_(ツ)_/¯ |
A follow-up of #6918 (comment) and the PR itself.
Tweaks the
import_map
query api to be more flexible with the ways to match against the import path and now fuzzy imports search in names only.This had improved the completion speed for me locally in ~5 times for
fuzzy_completion
span time, but please recheck me here.IMO we're fast and presice enough now, so I've added the modules back to the fuzzy search output.
Also tweaks the the expect tests to display functions explicitly, to avoid confusing "duplicate" results.