-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Automatically detect the rustc-src directory (fixes #3517) #7643
Conversation
Fwiw, this is blocked by rust-lang/rust#81997 so it works properly. |
|
I didn't know this, ok then. May I add that it can be useful in some cases, e.g. when a rustc version is pinned to a specific nightly, as may be done in alternative rustc compiler backends? (it's the case for rust-gpu right now) |
Yeah, I'd probably advice to commint settings.json to git. What we might do as well is so have opt-in auto-discovery. Ie, if the settings explicitly contain |
Cool idea; do you mean |
e7b6c4f
to
5d29039
Compare
I've now implemented this. It's a bit convoluted so that we're able to keep feature parity, namely the possibility to indicate a path relative to the root path; please let me know what you think of it! |
5d29039
to
aab5c9a
Compare
aab5c9a
to
4a6e602
Compare
Thanks for the review! The new version is much simpler 👍 |
bors r+ |
If the configured rustcSource was not set, then try to automatically
detect a source for the sysroot rustc directory.
I wasn't sure how to do it in the case of the project.json file, though.