Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement completion for associated items #801

Merged
merged 1 commit into from
Feb 12, 2019
Merged

Implement completion for associated items #801

merged 1 commit into from
Feb 12, 2019

Conversation

lnicola
Copy link
Member

@lnicola lnicola commented Feb 12, 2019 •
edited
Loading

Fixes #747.

r? @matklad

@lnicola lnicola force-pushed the complete-associated-items branch from 987bc7a to 8e88cc6 Compare February 12, 2019 08:36
@lnicola lnicola mentioned this pull request Feb 12, 2019
Closed
@lnicola lnicola force-pushed the complete-associated-items branch 3 times, most recently from 3d24b62 to 00451f8 Compare February 12, 2019 09:59
@lnicola lnicola changed the title [WIP] Implement completion for associated items Implement completion for associated items Feb 12, 2019
matklad
matklad reviewed Feb 12, 2019
View reviewed changes
Copy link
Member

@matklad matklad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM modulo couple of nits!

@lnicola lnicola force-pushed the complete-associated-items branch from 00451f8 to 140d8a9 Compare February 12, 2019 10:48
@lnicola lnicola force-pushed the complete-associated-items branch from 140d8a9 to 7e8527f Compare February 12, 2019 10:51
@lnicola
Copy link
Member Author

lnicola commented Feb 12, 2019

Addressed the nits.

@matklad
Copy link
Member

matklad commented Feb 12, 2019

bors r+

Thanks!

bors bot added a commit that referenced this pull request Feb 12, 2019
@bors @lnicola
Merge #801
19718ea 
801: Implement completion for associated items r=matklad a=lnicola

Fixes #747.

r? @matklad

Co-authored-by: Laurențiu Nicola <lnicola@dend.ro>
@lnicola
Copy link
Member Author

lnicola commented Feb 12, 2019

By the way, do you use rust-analyzer when working on rust-analyzer?

@matklad
Copy link
Member

matklad commented Feb 12, 2019

@lnicola yep, since about 133d001, was using IntelliJ Rust before that.

@lnicola
Copy link
Member Author

lnicola commented Feb 12, 2019

Weird, I found it hangs for tens of seconds to minutes when typing code, but maybe I'm doing something wrong.

@bors
Copy link
Contributor

bors bot commented Feb 12, 2019

Build succeeded

@bors bors bot merged commit 7e8527f into rust-lang:master Feb 12, 2019
@matklad
Copy link
Member

matklad commented Feb 12, 2019

Weird, I found it hangs for tens of seconds to minutes when typing code, but maybe I'm doing something wrong.

That's definitely not supposed to happen! On my machine, it needs a couple of seconds to do the first completion/symbol search (to populate caches), but after that it is more or less instantaneous for all operations.

Some troubleshooting questions:

  • what OS are you using?
  • are you sure you use the latest version of rust-analyzer?
  • are you sure you compile it with --release?
  • does the statistics in the Rust Analyzer: Status VS Code action looks reasonable?

@lnicola
Copy link
Member Author

lnicola commented Feb 12, 2019

Linux x64, latest version of everything, release build.

But never mind, I can't reproduce it after fully restarting VS Code (not just reloading the window).

@lnicola lnicola deleted the complete-associated-items branch February 12, 2019 12:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@matklad matklad matklad left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lnicola @matklad