Semantic highlight intradoclinks in documentation #8071
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Our intradoclink resolution certainly needs some improvement, most links I tried making didn't seem to work, here |
|
bors r+ |
matklad
reviewed
Mar 18, 2021
| (DOT, "dot"), | ||
| (ESCAPE_SEQUENCE, "escapeSequence"), | ||
| (FORMAT_SPECIFIER, "formatSpecifier"), | ||
| (GENERIC, "generic"), | ||
| (CONST_PARAMETER, "constParameter"), | ||
| (LIFETIME, "lifetime"), | ||
| (INTRA_DOC_LINK, "intraDocLink"), |
There was a problem hiding this comment.
Do we need a separate token type here? I think that we might want to set the type to the type of the pointed to item, and set modifier to "doc link". That is, treat links (the part that is a rust path) as small snippets of injected rust code.
There was a problem hiding this comment.
Oh that's a nice idea actually
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changelog feature highlight Intradoclinks in doc comments