Remove ref_match from CompletionItem #8393
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR makes two changes:
I discussed doing this in #8058, as a step toward fixing the problem where we put the reference completion in the wrong place for struct fields.
However, after implementing this, I'm not sure it improves on the existing code. I'm concerned that this implementation spreads the responsibility for reference completion around to too many places. Instead of this, next I want to try adding some kind of marker for where the reference would go in the
ref_matchfield. I don't intend to merge this PR, just wanted to open it as a draft in case there was any question about what this might look like.