Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

codegen: Generate u128 / i128 when available. #1391

Merged
merged 5 commits into from
Sep 19, 2018
Merged

codegen: Generate u128 / i128 when available. #1391

merged 5 commits into from
Sep 19, 2018

Conversation

emilio
Copy link
Contributor

@emilio emilio commented Sep 19, 2018

This is the first step to fix #1370 / #1338 / etc.

Fix for that will build up on this.

@highfive
Copy link

warning Warning warning

  • These commits modify unsafe code. Please review it carefully!

@emilio emilio mentioned this pull request Sep 19, 2018
Closed
@emilio
Copy link
Contributor Author

emilio commented Sep 19, 2018

I implemented the whole thing, but there's an autogenerated test failure that fails because of rust-lang/rust#54341.

So i128 / u128 doesn't have the right alignment on Rust :(

@emilio
Copy link
Contributor Author

emilio commented Sep 19, 2018

Still I think it's an improvement over what we have... So if I were to land this I'd disable the autogenerated tests for that test.

r? @fitzgen

@emilio
Always force repr(align) attributes for stuff with alignment >= 16
c09c74e 
To work-around some cases of rust-lang/rust#54341.

Other cases where u128 and u64 are mixed in fields might not behave correctly,
but the field offset assertions would catch them.

Fixes rust-lang#1370
@emilio
Copy link
Contributor Author

emilio commented Sep 19, 2018

Yeah, so I fixed it kind of, by always forcing repr(align) for such alignments. That makes all tests pass.

fitzgen
fitzgen approved these changes Sep 19, 2018
View reviewed changes
Copy link
Member

@fitzgen fitzgen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Would be valuable to have test coverage for the blob bits by making a test with a struct that contains a __int128 that is marked as opaque.

@emilio
Copy link
Contributor Author

emilio commented Sep 19, 2018

The blob bits unfortunately aren't an improvement over what we have because of that rust alignment issue, so I don't think we can land tests for them unless we have a way of expecting test failures, which I don't think I have the cycles for.

Thanks for the review!

@bors-servo r=fitzgen

@bors-servo
Copy link

📌 Commit c09c74e has been approved by fitzgen

@bors-servo
Copy link

⌛ Testing commit c09c74e with merge 6fc0a31...

bors-servo pushed a commit that referenced this pull request Sep 19, 2018
Auto merge of #1391 - emilio:u128, r=fitzgen
6fc0a31 
codegen: Generate u128 / i128 when available.

This is the first step to fix #1370 / #1338 / etc.

Fix for that will build up on this.
@bors-servo
Copy link

☀️ Test successful - status-travis
Approved by: fitzgen
Pushing 6fc0a31 to master...

@bors-servo bors-servo merged commit c09c74e into rust-lang:master Sep 19, 2018
This was referenced Oct 14, 2018
Closed
Closed
@ldm0 ldm0 mentioned this pull request Jun 10, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fitzgen fitzgen fitzgen approved these changes

Assignees

@fitzgen fitzgen

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Auto-generated test failure using <link.h> on Debian 9.
4 participants
@emilio @highfive @bors-servo @fitzgen