Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

options: Implement --version manually and print clang version on --version --verbose #2140

Merged
merged 1 commit into from
Jun 5, 2022

Conversation

emilio
Copy link
Contributor

@emilio emilio commented Dec 17, 2021

Fixes #2138

@bors-servo
Copy link

☔ The latest upstream changes (presumably be6d07a) made this pull request unmergeable. Please resolve the merge conflicts.

@bors-servo
Copy link

☔ The latest upstream changes (presumably cd78b65) made this pull request unmergeable. Please resolve the merge conflicts.

@kulp
Copy link
Member

kulp commented Jun 1, 2022

@emilio I rebased, and ran cargo +nightly fmt, and pushed a branch clang-version2 at 62e76e8 for this, in case you want to git reset --hard to that.

@kulp
Copy link
Member

kulp commented Jun 1, 2022

(Arguably I should have ordered "version" before "vtable-generation", though.)

@emilio
Copy link
Contributor Author

emilio commented Jun 5, 2022

Thanks, I cherry-picked that and also fixed the patch so that header was not required when specifying --version.

@emilio emilio merged commit 566d226 into master Jun 5, 2022
@emilio emilio deleted the clang-version branch June 5, 2022 18:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Querying bindgen for LLVM version being used
4 participants