Skip to content

Generated name override #2214

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 11 commits into from
Closed

Conversation

justsmth
Copy link
Contributor

@justsmth justsmth commented Jun 2, 2022

Addresses issue: #1375

  • Adds generated_name_override callback to the ParseCallbacks trait.
  • Callback is invoked for each function name (after other name-related logic).
  • Added test to verify.

@justsmth justsmth changed the title Link name override (#1375) Link name override (Issue #1375) Jun 2, 2022
@justsmth justsmth changed the title Link name override (Issue #1375) Link name override Jun 2, 2022
@bors-servo
Copy link

☔ The latest upstream changes (presumably 566d226) made this pull request unmergeable. Please resolve the merge conflicts.

@justsmth justsmth changed the title Link name override Generated name override Jun 6, 2022
@justsmth justsmth requested a review from emilio June 8, 2022 12:55
@justsmth
Copy link
Contributor Author

The msrv check above is failing with the following message:

Run rm Cargo.lock && cargo +1.54.0 build --lib
    Updating crates.io index
 Downloading crates ...
  Downloaded clap_lex v0.2.2
error: failed to parse manifest at `/home/runner/.cargo/registry/src/github.com-1ecc[6](https://github.com/rust-lang/rust-bindgen/runs/6907225276?check_suite_focus=true#step:4:7)299db9ec[8](https://github.com/rust-lang/rust-bindgen/runs/6907225276?check_suite_focus=true#step:4:9)23/clap_lex-0.2.2/Cargo.toml`
Caused by:
  feature `edition2021` is required
  this Cargo does not support nightly features, but if you
  switch to nightly channel you can add
  `cargo-features = ["edition2021"]` to enable this feature
Error: Process completed with exit code [10](https://github.com/rust-lang/rust-bindgen/runs/6907225276?check_suite_focus=true#step:4:11)1.

Is this a problem related to my change?

@justsmth
Copy link
Contributor Author

I created a separate PR for the bump to 1.56.1: #2225

@justsmth justsmth force-pushed the link_name_override branch from f399ec9 to 2338b13 Compare June 23, 2022 14:04
@justsmth
Copy link
Contributor Author

Moving to cleaned up PR: #2228

@justsmth justsmth closed this Jun 23, 2022
@justsmth justsmth deleted the link_name_override branch January 27, 2023 15:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants