-
Notifications
You must be signed in to change notification settings - Fork 718
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Handle no return attributes #2259
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks generally good, though I have some minor comments.
So it looks reasonable, but it's fairly unfortunate that we can't handle neither |
I can try and handle |
Weird, both test that failed pass on local (but I have a pretty recent clang version so that might be it). I'll try to bring back the UnexposedAttribute logic to check if that works. |
Fixed 🎉 |
@emilio now this supports all 3 options :) |
Any chance a new Bindgen release will pick this up anytime soon? I'm excited to use this :) EDIT: Never mind! This is already out, and I just don't know how to fetch tags :p |
I'm experiencing an issue that this PR should have dealt with. I'm thinking the reason could be that this was done for C++ and not for C. Is that restriction here? |
Without more information I'm unable to say. However, this feature works on c: // hello.h
__attribute__((noreturn)) void g(void); Then you run /* automatically generated by rust-bindgen 0.69.4 */
extern "C" {
pub fn g() -> !;
} |
I'm still seeing an issue on our end. Let me make a dedicated issue. |
Partially fixes #2094