-
Notifications
You must be signed in to change notification settings - Fork 738
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move codegen postprocessing to its own module #2282
Move codegen postprocessing to its own module #2282
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks great, thanks!
I have one suggestion that avoids some of the macro soup, let me know what you think. I implemented it in 0798bda.
I think it's a bit easier to follow, if you agree feel free to cherry-pick that on top before merging.
Thanks again!
@emilio, that's a pretty cool pattern! I'm going to steal it 😬 I did some changes to your commit so |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks lovely!
This PR moves all the
syn
based postprocessing to its own module insidecodegen
.