Skip to content

fix(args): make header argument optional #2678

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Nov 2, 2023
Merged

fix(args): make header argument optional #2678

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
fa9358c
fix(args): make header argument optional
orhun Nov 1, 2023
5607d85
refactor(args): avoid using type aliases
orhun Nov 2, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 6 additions & 2 deletions bindgen-cli/options.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -95,7 +95,7 @@ fn parse_custom_derive(
)]
struct BindgenCommand {
/// C or C++ header file.
header: String,
header: Option<String>,
/// Path to write depfile to.
#[arg(long)]
depfile: Option<String>,
Expand Down Expand Up @@ -589,7 +589,11 @@ where

let mut builder = builder();

builder = builder.header(header);
if let Some(header) = header {
builder = builder.header(header);
} else {
return Err(io::Error::new(io::ErrorKind::Other, "Header not found"));
}

if let Some(rust_target) = rust_target {
builder = builder.rust_target(rust_target);
Expand Down