Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix unsafe_op_in_unsafe_fn when using dynamic libraries and wrap_unsafe_ops #2961

Merged
merged 4 commits into from
Nov 5, 2024
Merged

Fix unsafe_op_in_unsafe_fn when using dynamic libraries and wrap_unsafe_ops #2961

merged 4 commits into from
Nov 5, 2024

Conversation

WardBrian
Copy link
Contributor

Closes #2957

@WardBrian
Copy link
Contributor Author

r? @pvdrz

@rustbot
Copy link
Collaborator

rustbot commented Oct 21, 2024

Error: The feature assign is not enabled in this repository.
To enable it add its section in the triagebot.toml in the root of the repository.

Please file an issue on GitHub at triagebot if there's a problem with this bot, or reach out on #t-infra on Zulip.

@WardBrian
Copy link
Contributor Author

The failing test looks like it is just because some part of the CI config has gone stale, possibly due to github updates?

@WardBrian
Copy link
Contributor Author

r? @emilio

@rustbot
Copy link
Collaborator

rustbot commented Nov 3, 2024

Error: The feature assign is not enabled in this repository.
To enable it add its section in the triagebot.toml in the root of the repository.

Please file an issue on GitHub at triagebot if there's a problem with this bot, or reach out on #t-infra on Zulip.

@pvdrz pvdrz added this pull request to the merge queue Nov 5, 2024
Merged via the queue into rust-lang:main with commit 492a942 Nov 5, 2024
33 checks passed
@WardBrian WardBrian deleted the issue-2957/dynamic-unsafe-ops branch November 5, 2024 17:04
@pvdrz pvdrz changed the title Fix unsafe_op_in_unsafe_fn when using dynamic librarys and wrap_unsafe_ops Fix unsafe_op_in_unsafe_fn when using dynamic libraries and wrap_unsafe_ops Dec 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pvdrz pvdrz pvdrz approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Combining dynamic_library with wrap_unsafe_ops still generates un-wrapped access to non-functions
3 participants
@WardBrian @rustbot @pvdrz