Add rust language editions support #3000
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nyurik
force-pushed
the
editions
branch
6 times, most recently
from
a750f6c to
1032dfa
Compare
Introduce a new `--rust-edition` parameter with allowed values 2015, 2018, 2021, and 2024. This allows different code generation depending on the language target. In this PR, the C-string literals are now generated differently depending on the language edition (literals like `c"example"` are not available before 2021)
nyurik
force-pushed
the
editions
branch
3 times, most recently
from
b98eb08 to
b4d00c4
Compare
This was referenced Nov 29, 2024
29 tasks
|
closed in favor of #3002 (sorry again 😱) |
|
no worries, thx for getting it done so fast! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduce a new
--rust-editionparameter with allowed values 2015, 2018, 2021, and 2024. This allows different code generation depending on the language target.In this PR, the C-string literals are now generated differently depending on the language edition (literals like
c"example"are not available before 2021)The default language edition uses logic:
--rust-targetis before 1.31.0, use2015--rust-targetversion is before 1.56.0, use2018In the future, it would be good to add these, if possible:
build.rs, detect current edition (is this possible?), and use the one of thebuild.rs