Option to avoid generating layout tests #632
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
fitzgen
approved these changes
Apr 14, 2017
src/codegen/mod.rs
Outdated
| @@ -987,37 +987,39 @@ impl CodeGenerator for TemplateInstantiation { | |||
| // just converted to rust types in fields, vars, etc, we take this | |||
| // opportunity to generate tests for their layout here. | |||
|
|
|||
| let layout = item.kind().expect_type().layout(ctx); | |||
| if ctx.options().layout_tests { | |||
There was a problem hiding this comment.
Rather than indenting tons of code, lets just early return here if we aren't generating layout tests.
| concat!("Alignment of ", stringify!($type_name))); | ||
| ) | ||
| }; | ||
| if ctx.options().layout_tests { |
There was a problem hiding this comment.
Unfortunately, we can't early return in this one because there is more work happening afterwards. It would be awesome if this layout test generation was factored into its own function, but I realize that is an extant problem that is a bit out of scope for this PR.
| @@ -214,29 +214,33 @@ impl Builder { | |||
| }) | |||
| .count(); | |||
|
|
|||
| if self.options.derive_debug == false { | |||
| if !self.options.layout_tests { | |||
| output_vector.push("--no-layout-tests".into()); | |||
There was a problem hiding this comment.
Thanks for updating this method too!
|
@bors-servo r+ Thanks @dimbleby! |
|
📌 Commit b8dd5c9 has been approved by |
bors-servo
pushed a commit
that referenced
this pull request
Apr 14, 2017
Option to avoid generating layout tests as discussed in #424
|
☀️ Test successful - status-travis |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
as discussed in #424