Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Small language mistake probably - in generics/bounds #1130

Closed
bartsmykla opened this issue Dec 16, 2018 · 3 comments
Closed

Small language mistake probably - in generics/bounds #1130

bartsmykla opened this issue Dec 16, 2018 · 3 comments
Labels
bug

Comments

@bartsmykla
Copy link
Contributor

Hi Rustaceans! :-)

I'm creating this issue because I'm not a native english speaker and I'm not sure if I'm right, but inside https://github.com/rust-lang/rust-by-example/blob/master/src/generics/bounds.md in lines 52-53 we can see:

// T must implement HasArea. Any function which meets
// the bound can access HasArea's function area.

Actually the parameter is not a function, so I think that there should be something like structure or other word. Am I correct?
@steveklabnik
Copy link
Member

I'd say type, yes. Thanks for this! i'd happily take a PR to fix it :)

@bartsmykla
Copy link
Contributor Author

I'm on it! :-)

bartsmykla pushed a commit to bartsmykla/rust-by-example that referenced this issue Dec 19, 2018
Changed word function to type in comment of fn area
d558f46 
Closes rust-lang#1130

Function area is taking generic type instead of function,
so word `type` is correct in that scenario as suggested by
@steveklabnik in issue rust-lang#1130

Signed-off-by: Bart Smykla <bsmykla@vmware.com>
@bartsmykla bartsmykla mentioned this issue Dec 19, 2018
Merged
@bartsmykla
Copy link
Contributor Author

@steveklabnik done: #1132

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@steveklabnik @bartsmykla