Migrated editions to 2021 and fixed conflicts #1489
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add the newest edition requirement 2021 in the book.toml
The present code is out of date due to 2021 edition and gives error on compile. Replacing extra & fixes it.
add _ in anonymous argument for the conflict to the new edition in trait Contains
specify the edition 2015 for the code to compile
|
Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @marioidival (or someone else) soon. Please see the contribution instructions for more information. |
|
The check is failed because the file rust-by-example/src/unsafe/asm.md compiled failed. The fail I think is reasonable due to the Add a page for inline assembly #1483 shown that "Tests are failing because the actual feature in rust-lang/rust hasn't been stabilized yet, but the FCP is done.". |
|
Inline assembly is fixed by #1490. |
|
@stupidodie and @Amanieu thank you for this 🙏 |
|
@stupidodie and @Amanieu thank you so much for you effort, but I'll close this PR because this was fixed in #1499 1499 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.