Add documentation for let-else. #1640
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @marioidival (or someone else) soon. Please see the contribution instructions for more information. |
|
@marioidival I see multiple pull requests that remain open. Do you not accept pull requests? |
|
@SebastianJL Hello. So, I'm an open source contributor. Just chill and we will merge your PR at time. Thank you |
|
Thanks a lot :) |
matthiaskrgr
added a commit
to matthiaskrgr/rust
that referenced
this pull request
Dec 19, 2022
Update books ## rust-lang/nomicon 1 commits in ae406aa5287a9e025abb72343aaceec98458c117..dd37e21ccee43918ed18a71581bb2af537ffe4fc 2022-12-09 22:04:38 UTC to 2022-12-09 22:04:38 UTC - Update lifetime-mismatch.md (rust-lang/nomicon#387) ## rust-lang/rust-by-example 3 commits in a9869b4a3c4cac3bc6099b41f088679e268400b8..995df09b65c582eb6290ab7ea5d9485983eb4c37 2022-12-08 23:29:31 UTC to 2022-12-08 23:28:31 UTC - Add documentation for let-else. (rust-lang/rust-by-example#1640) - Added missing space in comment (rust-lang/rust-by-example#1644) - Clean up Chapter 1 (Hello World) (rust-lang/rust-by-example#1650) ## rust-lang/rustc-dev-guide 8 commits in e269950..8b42eb5 2022-12-17 22:41:27 UTC to 2022-12-07 05:42:57 UTC - Add -Ztrack-diagnostics information (rust-lang/rustc-dev-guide#1506) - Add documentation for LLVM KCFI support (rust-lang/rustc-dev-guide#1529) - Replace references to NoLandingPads in MIR pass documents (rust-lang/rustc-dev-guide#1531) - share same link (rust-lang/rustc-dev-guide#1530) - chore: Update `actions/github-script` to v6 (rust-lang/rustc-dev-guide#1521) - fix: Fix broken links (rust-lang/rustc-dev-guide#1522) - Remove TyS (rust-lang/rustc-dev-guide#1526) - Fix small inaccuracy in monomorph page (rust-lang/rustc-dev-guide#1525)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Text mostly copied from the rust 1.65 announcement.
I inserted the section after
if letas it seemed the most natural to me.I used the wording
let-elseas opposed tolet elsebecause the rust 1.65 announcement does so as well.It might make sense to coordinate this with #1623.
Closes #1639