-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Expand macro section on repetition operators and syntax. #185
Conversation
//println!("{}", repeat_broken!(1u, 2u)); | ||
|
||
println!("{}", repeat_works!(1u)); | ||
// Would like it flat but it nests the results... |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I should remove this before pushing full website. Just noted because it's not an ideal example.
Rebased to tip, separated examples, and enabled playpen. Other changes should be mostly minor. Also, requested testing be supported in playpen: rust-lang/rust-playpen#32. It would be nice for the test suite example. |
@japaric: I think Variable numbered arguments (variable_args) and Variable separator options (separators) seem similar. It might be worth combining them. Also, it seems to me this fulfills your #110 checklist aside from Repetition and expansion awkwardly having 2 examples and the Generating generic test suite implementations not running on purpose... If you had more in mind for expansion, you might want to update that list. |
@@ -1,2 +1,3 @@ | |||
bin/* | |||
stage/* | |||
*~ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What is this for?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hide gedit temp files. I can remove it if you want...I just added it because it might be a good idea.
[EDIT]
Let me know if you want this.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please remove it
{ "id": "macros", "title": "macro_rules!", "children": null }, | ||
{ "id": "macros", "title": "macro_rules!", "children": [ | ||
{ "id": "arguments", "title": "Arguments and designators", "children": null }, | ||
{ "id": "variable_args", "title": "Variadic macros", "children": null }, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Remove Variadic macros. See #185 (comment)
Same here, @mdinger |
Oops. They are different. #200 is a followup to this. |
I'll rebase and reopen if I decide to work on this. Closing. |
This is to give more details on how macro repetition works and to address #110 (comment).